Commit f29eb2a9 authored Nov 07, 2018 by Paolo Abeni Committed by David S. Miller Nov 07, 2018

tun: compute the RFS hash only if needed.



The tun XDP sendmsg code path, unconditionally computes the symmetric
hash of each packet for RFS's sake, even when we could skip it. e.g.
when the device has a single queue.

This change adds the check already in-place for the skb sendmsg path
to avoid unneeded hashing.

The above gives small, but measurable, performance gain for VM xmit
path when zerocopy is not enabled.

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2e7ad56a

drivers/net/tun.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -2448,7 +2448,8 @@ build:
		goto out;
		}

		if (!rcu_dereference(tun->steering_prog))
		if (!rcu_dereference(tun->steering_prog) && tun->numqueues > 1 &&
		!tfile->detached)
		rxhash = __skb_get_hash_symmetric(skb);

		netif_receive_skb(skb);

Admin message