Commit f29e0880 authored Jun 16, 2020 by Gustavo A. R. Silva Committed by Chris Wilson Jun 16, 2020

drm/i915/selftests: Fix inconsistent IS_ERR and PTR_ERR

Fix inconsistent IS_ERR and PTR_ERR in live_timeslice_nopreempt().

The proper pointer to be passed as argument to PTR_ERR() is ce.

This bug was detected with the help of Coccinelle.

Fixes: b72f02d7 ("drm/i915/gt: Prevent timeslicing into unpreemptable requests")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20200616145452.GA25291@embeddedor

parent 570af07d

drivers/gpu/drm/i915/gt/selftest_lrc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1337,7 +1337,7 @@ static int live_timeslice_nopreempt(void *arg)

		ce = intel_context_create(engine);
		if (IS_ERR(ce)) {
		err = PTR_ERR(rq);
		err = PTR_ERR(ce);
		goto out_spin;
		}