Commit f29808b2 authored Mar 26, 2020 by John Stultz Committed by Bjorn Andersson Apr 14, 2020

soc: qcom: rpmpd: Allow RPMPD driver to be loaded as a module

This patch allow the rpmpd driver to be loaded as a permenent
module. Meaning it can be loaded from a module, but then cannot
be unloaded.

Ideally, it would include a remove hook and related logic, but
apparently the genpd code isn't able to track usage and cleaning
things up? (See: https://lkml.org/lkml/2019/1/24/38

)

So making it a permenent module at least improves things slightly
over requiring it to be a built in driver.

Cc: Todd Kjos <tkjos@google.com>
Cc: Saravana Kannan <saravanak@google.com>
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rajendra Nayak <rnayak@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
Acked-by: Saravana Kannan <saravanak@google.com>
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Link: https://lore.kernel.org/r/20200326224459.105170-2-john.stultz@linaro.org


Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent d4889ec1

drivers/soc/qcom/Kconfig

+2 −2

Original line number	Diff line number	Diff line
		@@ -126,8 +126,8 @@ config QCOM_RPMHPD
		for the voltage rail.

		config QCOM_RPMPD
		bool "Qualcomm RPM Power domain driver"
		depends on QCOM_SMD_RPM=y
		tristate "Qualcomm RPM Power domain driver"
		depends on QCOM_SMD_RPM
		help
		QCOM RPM Power domain driver to support power-domains with
		performance states. The driver communicates a performance state

drivers/soc/qcom/rpmpd.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -4,6 +4,7 @@
		#include <linux/err.h>
		#include <linux/init.h>
		#include <linux/kernel.h>
		#include <linux/module.h>
		#include <linux/mutex.h>
		#include <linux/pm_domain.h>
		#include <linux/of.h>
		@@ -226,6 +227,7 @@ static const struct of_device_id rpmpd_match_table[] = {
		{ .compatible = "qcom,qcs404-rpmpd", .data = &qcs404_desc },
		{ }
		};
		MODULE_DEVICE_TABLE(of, rpmpd_match_table);

		static int rpmpd_send_enable(struct rpmpd *pd, bool enable)
		{
		@@ -422,3 +424,6 @@ static int __init rpmpd_init(void)
		return platform_driver_register(&rpmpd_driver);
		}
		core_initcall(rpmpd_init);

		MODULE_DESCRIPTION("Qualcomm Technologies, Inc. RPM Power Domain Driver");
		MODULE_LICENSE("GPL v2");

Admin message