Commit f275ee0f authored Jan 10, 2019 by Greg Kroah-Hartman Committed by David S. Miller Jan 15, 2019

IN_BADCLASS: fix macro to actually work



Commit 65cab850 ("net: Allow class-e address assignment via ifconfig
ioctl") modified the IN_BADCLASS macro a bit, but unfortunatly one too
many '(' characters were added to the line, making any code that used
it, not build properly.

Also, the macro now compares an unsigned with a signed value, which
isn't ok, so fix that up by making both types match properly.

Reported-by: Christopher Ferris <cferris@google.com>
Fixes: 65cab850 ("net: Allow class-e address assignment via ifconfig ioctl")
Cc: Dave Taht <dave.taht@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 13d7f463

include/uapi/linux/in.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -268,7 +268,7 @@ struct sockaddr_in {
		#define IN_MULTICAST(a) IN_CLASSD(a)
		#define IN_MULTICAST_NET 0xe0000000

		#define IN_BADCLASS(a) ((((long int) (a) ) == 0xffffffff)
		#define IN_BADCLASS(a) (((long int) (a) ) == (long int)0xffffffff)
		#define IN_EXPERIMENTAL(a) IN_BADCLASS((a))

		#define IN_CLASSE(a) ((((long int) (a)) & 0xf0000000) == 0xf0000000)

Admin message