Commit f2750df1 authored Sep 28, 2018 by Florian Fainelli Committed by David S. Miller Sep 29, 2018

r8152: Check for supported Wake-on-LAN Modes



The driver does not check for Wake-on-LAN modes specified by an user,
but will conditionally set the device as wake-up enabled or not based on
that, which could be a very confusing user experience.

Fixes: 21ff2e89 ("r8152: support WOL")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c5cb93e9

drivers/net/usb/r8152.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -4506,6 +4506,9 @@ static int rtl8152_set_wol(struct net_device dev, struct ethtool_wolinfo wol)
		if (!rtl_can_wakeup(tp))
		return -EOPNOTSUPP;

		if (wol->wolopts & ~WAKE_ANY)
		return -EINVAL;

		ret = usb_autopm_get_interface(tp->intf);
		if (ret < 0)
		goto out_set_wol;

Admin message