Commit f26e6016 authored Oct 04, 2017 by Josh Poimboeuf Committed by Radim Krčmář Oct 05, 2017

x86/kvm: Move kvm_fastop_exception to .fixup section



When compiling the kernel with the '-frecord-gcc-switches' flag, objtool
complains:

  arch/x86/kvm/emulate.o: warning: objtool: .GCC.command.line+0x0: special: can't find new instruction

And also the kernel fails to link.

The problem is that the 'kvm_fastop_exception' code gets placed into the
throwaway '.GCC.command.line' section instead of '.text'.

Exception fixup code is conventionally placed in the '.fixup' section,
so put it there where it belongs.

Reported-and-tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

parent a2b7861b

arch/x86/kvm/emulate.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -425,8 +425,10 @@ static int fastop(struct x86_emulate_ctxt ctxt, void (fop)(struct fastop *));
		#op " %al \n\t" \
		FOP_RET

		asm(".global kvm_fastop_exception \n"
		"kvm_fastop_exception: xor %esi, %esi; ret");
		asm(".pushsection .fixup, \"ax\"\n"
		".global kvm_fastop_exception \n"
		"kvm_fastop_exception: xor %esi, %esi; ret\n"
		".popsection");

		FOP_START(setcc)
		FOP_SETCC(seto)

Admin message