Commit f2586c67 authored Jul 20, 2017 by Keith Busch Committed by Bjorn Helgaas Aug 03, 2017

PCI: vmd: Assign vector zero to all bridges

We don't want slower IRQ handlers impacting faster devices that happen to
be assigned the same VMD interrupt vector. The driver was trying to
separate such devices by checking if MSI-X wasn't used, but really we just
don't want endpoint devices to share with bridges. Most bridges may use MSI
currently, so that criteria happened to work, but newer ones may use MSI-X,
so this patch explicitly checks the device type when choosing a vector.

Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent 37d7f818

drivers/pci/host/vmd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -183,7 +183,7 @@ static struct vmd_irq_list vmd_next_irq(struct vmd_dev vmd, struct msi_desc *d
		int i, best = 1;
		unsigned long flags;

		if (!desc->msi_attrib.is_msix \|\| vmd->msix_count == 1)
		if (pci_is_bridge(msi_desc_to_pci_dev(desc)) \|\| vmd->msix_count == 1)
		return &vmd->irqs[0];

		raw_spin_lock_irqsave(&list_lock, flags);

Admin message