Commit f25372ff authored Feb 14, 2020 by Yi Zhang Committed by Jens Axboe Feb 14, 2020

nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info



nvme fw-activate operation will get bellow warning log,
fix it by update the parameter order

[  113.231513] nvme nvme0: Get FW SLOT INFO log error

Fixes: 0e98719b ("nvme: simplify the API for getting log pages")
Reported-by: Sujith Pandel <sujith_pandel@dell.com>
Reviewed-by: David Milburn <dmilburn@redhat.com>
Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent fa46c6fb

drivers/nvme/host/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3867,7 +3867,7 @@ static void nvme_get_fw_slot_info(struct nvme_ctrl *ctrl)
		if (!log)
		return;

		if (nvme_get_log(ctrl, NVME_NSID_ALL, 0, NVME_LOG_FW_SLOT, log,
		if (nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_FW_SLOT, 0, log,
		sizeof(*log), 0))
		dev_warn(ctrl->device, "Get FW SLOT INFO log error\n");
		kfree(log);

Admin message