Commit f23d538b authored Oct 23, 2015 by Jason Wang Committed by David S. Miller Oct 23, 2015

macvtap: unbreak receiving of gro skb with frag list



We don't have fraglist support in TAP_FEATURES. This will lead
software segmentation of gro skb with frag list. Fixes by having
frag list support in TAP_FEATURES.

With this patch single session of netperf receiving were restored from
about 5Gb/s to about 12Gb/s on mlx4.

Fixes a567dd62 ("macvtap: simplify usage of tap_features")
Cc: Vlad Yasevich <vyasevic@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fc4099f1

drivers/net/macvtap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -137,7 +137,7 @@ static const struct proto_ops macvtap_socket_ops;
		#define TUN_OFFLOADS (NETIF_F_HW_CSUM \| NETIF_F_TSO_ECN \| NETIF_F_TSO \| \
		NETIF_F_TSO6 \| NETIF_F_UFO)
		#define RX_OFFLOADS (NETIF_F_GRO \| NETIF_F_LRO)
		#define TAP_FEATURES (NETIF_F_GSO \| NETIF_F_SG)
		#define TAP_FEATURES (NETIF_F_GSO \| NETIF_F_SG \| NETIF_F_FRAGLIST)

		static struct macvlan_dev macvtap_get_vlan_rcu(const struct net_device dev)
		{

Original line number	Diff line number	Diff line
		@@ -137,7 +137,7 @@ static const struct proto_ops macvtap_socket_ops;
		#define TUN_OFFLOADS (NETIF_F_HW_CSUM \| NETIF_F_TSO_ECN \| NETIF_F_TSO \| \
		NETIF_F_TSO6 \| NETIF_F_UFO)
		#define RX_OFFLOADS (NETIF_F_GRO \| NETIF_F_LRO)
		#define TAP_FEATURES (NETIF_F_GSO \| NETIF_F_SG)
		#define TAP_FEATURES (NETIF_F_GSO \| NETIF_F_SG \| NETIF_F_FRAGLIST)

		static struct macvlan_dev macvtap_get_vlan_rcu(const struct net_device dev)
		{

Admin message