Commit f2176d72 authored Sep 28, 2010 by Juuso Oikarinen Committed by John W. Linville Sep 28, 2010

mac80211: Fix WMM driver queue configuration



The WMM parameter configuration function (ieee80211_sta_wmm_params) only
configures the WMM parameters to the driver is the wmm_last_param_set
counter value is changed by the AP.

The wmm_last_param_set is initialized to -1 on association in order to ensure
the configuration is made to the driver at least once on association, but
currently this initialization is done *after* the WMM parameter configuration
function was called.

This leads to unreliability in the driver getting properly configured on first
association (depending on what counter value the AP happens to use.) When
disassociating (the wmm default parameters are configured to the driver) and
then reassociating, due to the above the WMM configuration is not set to the
driver at all.

On drivers without beacon filtering the problem is corrected by later beacons,
but on drivers with beacon filtering the WMM will remain permanently incorrectly
configured.

Fix this by moving the initialization of wmm_last_param_set to -1 before
ieee80211_sta_wmm_params is called on association.

Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 93b05238

net/mac80211/mlme.c

+8 −8

Original line number	Diff line number	Diff line
		@@ -880,14 +880,6 @@ static void ieee80211_set_associated(struct ieee80211_sub_if_data *sdata,
		sdata->u.mgd.flags &= ~(IEEE80211_STA_CONNECTION_POLL \|
		IEEE80211_STA_BEACON_POLL);

		/*
		* Always handle WMM once after association regardless
		* of the first value the AP uses. Setting -1 here has
		* that effect because the AP values is an unsigned
		* 4-bit value.
		*/
		sdata->u.mgd.wmm_last_param_set = -1;

		ieee80211_led_assoc(local, 1);

		if (local->hw.flags & IEEE80211_HW_NEED_DTIM_PERIOD)
		@@ -1367,6 +1359,14 @@ static bool ieee80211_assoc_success(struct ieee80211_work *wk,
		return false;
		}

		/*
		* Always handle WMM once after association regardless
		* of the first value the AP uses. Setting -1 here has
		* that effect because the AP values is an unsigned
		* 4-bit value.
		*/
		ifmgd->wmm_last_param_set = -1;

		if (elems.wmm_param)
		ieee80211_sta_wmm_params(local, sdata, elems.wmm_param,
		elems.wmm_param_len);

Admin message