zbud: avoid accessing last unused freelist (f203c3b3) · Commits · 戴 / test

For now, there are NCHUNKS of 64 freelists in zbud_pool, the last unbuddied[63] freelist linked with all zbud pages which have free chunks of 63. Calculating according to context of num_free_chunks(), our max chunk number of unbuddied zbud page is 62, so none of zbud pages will be added/removed in last freelist, but still we will try to find an unbuddied zbud page in the last unused freelist, it is unneeded. This patch redefines NCHUNKS to 63 as free chunk number in one zbud page, hence we can decrease size of zpool and avoid accessing the last unused freelist whenever failing to allocate zbud from freelist in zbud_alloc. Signed-off-by:

Chao Yu <chao2.yu@samsung.com> Cc: Seth Jennings <sjennings@variantweb.net> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

mm/zbud.c

+7 −6

Original line number	Diff line number	Diff line
		@@ -60,15 +60,17 @@
		* NCHUNKS_ORDER determines the internal allocation granularity, effectively
		* adjusting internal fragmentation. It also determines the number of
		* freelists maintained in each pool. NCHUNKS_ORDER of 6 means that the
		* allocation granularity will be in chunks of size PAGE_SIZE/64, and there
		* will be 64 freelists per pool.
		* allocation granularity will be in chunks of size PAGE_SIZE/64. As one chunk
		* in allocated page is occupied by zbud header, NCHUNKS will be calculated to
		* 63 which shows the max number of free chunks in zbud page, also there will be
		* 63 freelists per pool.
		*/
		#define NCHUNKS_ORDER 6

		#define CHUNK_SHIFT (PAGE_SHIFT - NCHUNKS_ORDER)
		#define CHUNK_SIZE (1 << CHUNK_SHIFT)
		#define NCHUNKS (PAGE_SIZE >> CHUNK_SHIFT)
		#define ZHDR_SIZE_ALIGNED CHUNK_SIZE
		#define NCHUNKS ((PAGE_SIZE - ZHDR_SIZE_ALIGNED) >> CHUNK_SHIFT)

		/**
		* struct zbud_pool - stores metadata for each zbud pool
		@@ -268,10 +270,9 @@ static int num_free_chunks(struct zbud_header *zhdr)
		{
		/*
		* Rather than branch for different situations, just use the fact that
		* free buddies have a length of zero to simplify everything. -1 at the
		* end for the zbud header.
		* free buddies have a length of zero to simplify everything.
		*/
		return NCHUNKS - zhdr->first_chunks - zhdr->last_chunks - 1;
		return NCHUNKS - zhdr->first_chunks - zhdr->last_chunks;
		}

		/*****************

Admin message