Commit f1f88fc7 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

SUNRPC: The function rpc_restart_call() should return success/failure 



Both rpc_restart_call_prepare() and rpc_restart_call() test for the
RPC_TASK_KILLED flag, and fail to restart the RPC call if that flag is set.

This patch allows callers to know whether or not the restart was
successful, so that they can perform cleanups etc in case of failure.

Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent a6f03393

include/linux/sunrpc/clnt.h

+2 −2
Original line number Diff line number Diff line
@@ -148,8 +148,8 @@ int rpc_call_sync(struct rpc_clnt *clnt, 
			      const struct rpc_message *msg, int flags);

struct rpc_task *rpc_call_null(struct rpc_clnt *clnt, struct rpc_cred *cred,

			       int flags);

void		rpc_restart_call_prepare(struct rpc_task *);

void		rpc_restart_call(struct rpc_task *);

int		rpc_restart_call_prepare(struct rpc_task *);

int		rpc_restart_call(struct rpc_task *);

void		rpc_setbufsize(struct rpc_clnt *, unsigned int, unsigned int);

size_t		rpc_max_payload(struct rpc_clnt *);

void		rpc_force_rebind(struct rpc_clnt *);

net/sunrpc/clnt.c

+6 −5
Original line number Diff line number Diff line
@@ -756,12 +756,13 @@ EXPORT_SYMBOL_GPL(rpc_force_rebind); 
 * Restart an (async) RPC call from the call_prepare state.

 * Usually called from within the exit handler.

 */

void

int

rpc_restart_call_prepare(struct rpc_task *task)

{

	if (RPC_ASSASSINATED(task))

		return;

		return 0;

	task->tk_action = rpc_prepare_task;

	return 1;

}

EXPORT_SYMBOL_GPL(rpc_restart_call_prepare);
@@ -769,13 +770,13 @@ EXPORT_SYMBOL_GPL(rpc_restart_call_prepare); 
 * Restart an (async) RPC call. Usually called from within the

 * exit handler.

 */

void

int

rpc_restart_call(struct rpc_task *task)

{

	if (RPC_ASSASSINATED(task))

		return;



		return 0;

	task->tk_action = call_start;

	return 1;

}

EXPORT_SYMBOL_GPL(rpc_restart_call);

CRA Git | Maintained and supported by SUSTech CRA and CCSE