Commit f1d2564a authored Jan 10, 2018 by Daeho Jeong Committed by Jaegeuk Kim Jan 18, 2018

f2fs: handle newly created page when revoking inmem pages



When committing inmem pages is successful, we revoke already committed
blocks in __revoke_inmem_pages() and finally replace the committed
ones with the old blocks using f2fs_replace_block(). However, if
the committed block was newly created one, the address of the old
block is NEW_ADDR and __f2fs_replace_block() cannot handle NEW_ADDR
as new_blkaddr properly and a kernel panic occurrs.

Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com>
Tested-by: Shu Tan <shu.tan@samsung.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

parent 7c2e5963

fs/f2fs/segment.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -248,6 +248,10 @@ retry:
		goto next;
		}
		get_node_info(sbi, dn.nid, &ni);
		if (cur->old_addr == NEW_ADDR) {
		invalidate_blocks(sbi, dn.data_blkaddr);
		f2fs_update_data_blkaddr(&dn, NEW_ADDR);
		} else
		f2fs_replace_block(sbi, &dn, dn.data_blkaddr,
		cur->old_addr, ni.version, true, true);
		f2fs_put_dnode(&dn);

Admin message