Commit f1cd93f9 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: Rename VPD symbols to remove unnecessary "pci22" 



There's only one kind of VPD, so we don't need to qualify it as "the
version described by PCI spec rev 2.2."

Rename the following symbols to remove unnecessary "pci22":

  PCI_VPD_PCI22_SIZE	-> PCI_VPD_MAX_SIZE
  pci_vpd_pci22_size()	-> pci_vpd_size()
  pci_vpd_pci22_wait()	-> pci_vpd_wait()
  pci_vpd_pci22_read()	-> pci_vpd_read()
  pci_vpd_pci22_write()	-> pci_vpd_write()
  pci_vpd_pci22_ops	-> pci_vpd_ops
  pci_vpd_pci22_init()	-> pci_vpd_init()

Tested-by: default avatarShane Seymour <shane.seymour@hpe.com>
Tested-by: default avatarBabu Moger <babu.moger@oracle.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
parent da006847

drivers/pci/access.c

+19 −19
Original line number Original line Diff line number Diff line
@@ -275,7 +275,7 @@ ssize_t pci_write_vpd(struct pci_dev *dev, loff_t pos, size_t count, const void 
}

}

EXPORT_SYMBOL(pci_write_vpd);

EXPORT_SYMBOL(pci_write_vpd);





#define PCI_VPD_PCI22_SIZE (PCI_VPD_ADDR_MASK + 1)

#define PCI_VPD_MAX_SIZE (PCI_VPD_ADDR_MASK + 1)





struct pci_vpd_pci22 {

struct pci_vpd_pci22 {

	struct pci_vpd base;

	struct pci_vpd base;
@@ -291,7 +291,7 @@ struct pci_vpd_pci22 { 
 * @dev:	pci device struct

 * @dev:	pci device struct

 * @old_size:	current assumed size, also maximum allowed size

 * @old_size:	current assumed size, also maximum allowed size

 */

 */

static size_t pci_vpd_pci22_size(struct pci_dev *dev, size_t old_size)

static size_t pci_vpd_size(struct pci_dev *dev, size_t old_size)

{

{

	size_t off = 0;

	size_t off = 0;

	unsigned char header[1+2];	/* 1 byte tag, 2 bytes length */

	unsigned char header[1+2];	/* 1 byte tag, 2 bytes length */
@@ -348,7 +348,7 @@ static size_t pci_vpd_pci22_size(struct pci_dev *dev, size_t old_size) 
 *

 *

 * Returns 0 on success, negative values indicate error.

 * Returns 0 on success, negative values indicate error.

 */

 */

static int pci_vpd_pci22_wait(struct pci_dev *dev)

static int pci_vpd_wait(struct pci_dev *dev)

{

{

	struct pci_vpd_pci22 *vpd =

	struct pci_vpd_pci22 *vpd =

		container_of(dev->vpd, struct pci_vpd_pci22, base);

		container_of(dev->vpd, struct pci_vpd_pci22, base);
@@ -381,7 +381,7 @@ static int pci_vpd_pci22_wait(struct pci_dev *dev) 
	}

	}

}

}





static ssize_t pci_vpd_pci22_read(struct pci_dev *dev, loff_t pos, size_t count,

static ssize_t pci_vpd_read(struct pci_dev *dev, loff_t pos, size_t count,

			    void *arg)

			    void *arg)

{

{

	struct pci_vpd_pci22 *vpd =

	struct pci_vpd_pci22 *vpd =
@@ -395,7 +395,7 @@ static ssize_t pci_vpd_pci22_read(struct pci_dev *dev, loff_t pos, size_t count, 




	if (!vpd->valid) {

	if (!vpd->valid) {

		vpd->valid = 1;

		vpd->valid = 1;

		vpd->base.len = pci_vpd_pci22_size(dev, vpd->base.len);

		vpd->base.len = pci_vpd_size(dev, vpd->base.len);

	}

	}





	if (vpd->base.len == 0)

	if (vpd->base.len == 0)
@@ -412,7 +412,7 @@ static ssize_t pci_vpd_pci22_read(struct pci_dev *dev, loff_t pos, size_t count, 
	if (mutex_lock_killable(&vpd->lock))

	if (mutex_lock_killable(&vpd->lock))

		return -EINTR;

		return -EINTR;





	ret = pci_vpd_pci22_wait(dev);

	ret = pci_vpd_wait(dev);

	if (ret < 0)

	if (ret < 0)

		goto out;

		goto out;
@@ -426,7 +426,7 @@ static ssize_t pci_vpd_pci22_read(struct pci_dev *dev, loff_t pos, size_t count, 
			break;

			break;

		vpd->busy = 1;

		vpd->busy = 1;

		vpd->flag = PCI_VPD_ADDR_F;

		vpd->flag = PCI_VPD_ADDR_F;

		ret = pci_vpd_pci22_wait(dev);

		ret = pci_vpd_wait(dev);

		if (ret < 0)

		if (ret < 0)

			break;

			break;
@@ -449,7 +449,7 @@ out: 
	return ret ? ret : count;

	return ret ? ret : count;

}

}





static ssize_t pci_vpd_pci22_write(struct pci_dev *dev, loff_t pos, size_t count,

static ssize_t pci_vpd_write(struct pci_dev *dev, loff_t pos, size_t count,

			     const void *arg)

			     const void *arg)

{

{

	struct pci_vpd_pci22 *vpd =

	struct pci_vpd_pci22 *vpd =
@@ -463,7 +463,7 @@ static ssize_t pci_vpd_pci22_write(struct pci_dev *dev, loff_t pos, size_t count 




	if (!vpd->valid) {

	if (!vpd->valid) {

		vpd->valid = 1;

		vpd->valid = 1;

		vpd->base.len = pci_vpd_pci22_size(dev, vpd->base.len);

		vpd->base.len = pci_vpd_size(dev, vpd->base.len);

	}

	}





	if (vpd->base.len == 0)

	if (vpd->base.len == 0)
@@ -475,7 +475,7 @@ static ssize_t pci_vpd_pci22_write(struct pci_dev *dev, loff_t pos, size_t count 
	if (mutex_lock_killable(&vpd->lock))

	if (mutex_lock_killable(&vpd->lock))

		return -EINTR;

		return -EINTR;





	ret = pci_vpd_pci22_wait(dev);

	ret = pci_vpd_wait(dev);

	if (ret < 0)

	if (ret < 0)

		goto out;

		goto out;
@@ -497,7 +497,7 @@ static ssize_t pci_vpd_pci22_write(struct pci_dev *dev, loff_t pos, size_t count 




		vpd->busy = 1;

		vpd->busy = 1;

		vpd->flag = 0;

		vpd->flag = 0;

		ret = pci_vpd_pci22_wait(dev);

		ret = pci_vpd_wait(dev);

		if (ret < 0)

		if (ret < 0)

			break;

			break;
@@ -508,9 +508,9 @@ out: 
	return ret ? ret : count;

	return ret ? ret : count;

}

}





static const struct pci_vpd_ops pci_vpd_pci22_ops = {

static const struct pci_vpd_ops pci_vpd_ops = {

	.read = pci_vpd_pci22_read,

	.read = pci_vpd_read,

	.write = pci_vpd_pci22_write,

	.write = pci_vpd_write,

};

};





static ssize_t pci_vpd_f0_read(struct pci_dev *dev, loff_t pos, size_t count,

static ssize_t pci_vpd_f0_read(struct pci_dev *dev, loff_t pos, size_t count,
@@ -548,7 +548,7 @@ static const struct pci_vpd_ops pci_vpd_f0_ops = { 
	.write = pci_vpd_f0_write,

	.write = pci_vpd_f0_write,

};

};





int pci_vpd_pci22_init(struct pci_dev *dev)

int pci_vpd_init(struct pci_dev *dev)

{

{

	struct pci_vpd_pci22 *vpd;

	struct pci_vpd_pci22 *vpd;

	u8 cap;

	u8 cap;
@@ -561,11 +561,11 @@ int pci_vpd_pci22_init(struct pci_dev *dev) 
	if (!vpd)

	if (!vpd)

		return -ENOMEM;

		return -ENOMEM;





	vpd->base.len = PCI_VPD_PCI22_SIZE;

	vpd->base.len = PCI_VPD_MAX_SIZE;

	if (dev->dev_flags & PCI_DEV_FLAGS_VPD_REF_F0)

	if (dev->dev_flags & PCI_DEV_FLAGS_VPD_REF_F0)

		vpd->base.ops = &pci_vpd_f0_ops;

		vpd->base.ops = &pci_vpd_f0_ops;

	else

	else

		vpd->base.ops = &pci_vpd_pci22_ops;

		vpd->base.ops = &pci_vpd_ops;

	mutex_init(&vpd->lock);

	mutex_init(&vpd->lock);

	vpd->cap = cap;

	vpd->cap = cap;

	vpd->busy = 0;

	vpd->busy = 0;

drivers/pci/pci.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -105,7 +105,7 @@ struct pci_vpd { 
	struct bin_attribute *attr; /* descriptor for sysfs VPD entry */

	struct bin_attribute *attr; /* descriptor for sysfs VPD entry */

};

};





int pci_vpd_pci22_init(struct pci_dev *dev);

int pci_vpd_init(struct pci_dev *dev);

void pci_vpd_release(struct pci_dev *dev);

void pci_vpd_release(struct pci_dev *dev);





/* PCI /proc functions */

/* PCI /proc functions */

drivers/pci/probe.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1608,7 +1608,7 @@ static void pci_init_capabilities(struct pci_dev *dev) 
	pci_pm_init(dev);

	pci_pm_init(dev);





	/* Vital Product Data */

	/* Vital Product Data */

	pci_vpd_pci22_init(dev);

	pci_vpd_init(dev);





	/* Alternative Routing-ID Forwarding */

	/* Alternative Routing-ID Forwarding */

	pci_configure_ari(dev);

	pci_configure_ari(dev);

CRA Git | Maintained and supported by SUSTech CRA and CCSE