Commit f1aba0a0 authored Dec 20, 2017 by Niklas Cassel Committed by Lorenzo Pieralisi Dec 21, 2017

PCI: dwc: dra7xx: Help compiler to remove unused code



The dra7xx driver supports both host and ep mode.
When enabling support for only one of the modes, help the compiler
to remove code for the mode that we have not enabled in the driver.

By adding if (!IS_ENABLED(CONFIG_PCI_DRA7XX_HOST)) return -ENODEV;
anything after that statement will get silently dropped by the compiler,
including static functions and structures that are referenced indirectly
from there.

Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>

parent 71890ea0

drivers/pci/dwc/pci-dra7xx.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -694,6 +694,11 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)

		switch (mode) {
		case DW_PCIE_RC_TYPE:
		if (!IS_ENABLED(CONFIG_PCI_DRA7XX_HOST)) {
		ret = -ENODEV;
		goto err_gpio;
		}

		dra7xx_pcie_writel(dra7xx, PCIECTRL_TI_CONF_DEVICE_TYPE,
		DEVICE_TYPE_RC);
		ret = dra7xx_add_pcie_port(dra7xx, pdev);
		@@ -701,6 +706,11 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
		goto err_gpio;
		break;
		case DW_PCIE_EP_TYPE:
		if (!IS_ENABLED(CONFIG_PCI_DRA7XX_EP)) {
		ret = -ENODEV;
		goto err_gpio;
		}

		dra7xx_pcie_writel(dra7xx, PCIECTRL_TI_CONF_DEVICE_TYPE,
		DEVICE_TYPE_EP);

Admin message