workqueue: Use IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO. (f187b697) · Commits · 戴 / test

Replace inline function PTR_ERR_OR_ZERO with IS_ERR and PTR_ERR to remove redundant parameter definitions and checks. Reduce code size. Before: text data bss dec hex filename 47510 5979 840 54329 d439 kernel/workqueue.o After: text data bss dec hex filename 47474 5979 840 54293 d415 kernel/workqueue.o Signed-off-by:

Sean Fu <fxinrong@gmail.com> Signed-off-by:

Tejun Heo <tj@kernel.org>

kernel/workqueue.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -4197,7 +4197,6 @@ static int wq_clamp_max_active(int max_active, unsigned int flags,
		static int init_rescuer(struct workqueue_struct *wq)
		{
		struct worker *rescuer;
		int ret;

		if (!(wq->flags & WQ_MEM_RECLAIM))
		return 0;
		@@ -4208,10 +4207,9 @@ static int init_rescuer(struct workqueue_struct *wq)

		rescuer->rescue_wq = wq;
		rescuer->task = kthread_create(rescuer_thread, rescuer, "%s", wq->name);
		ret = PTR_ERR_OR_ZERO(rescuer->task);
		if (ret) {
		if (IS_ERR(rescuer->task)) {
		kfree(rescuer);
		return ret;
		return PTR_ERR(rescuer->task);
		}

		wq->rescuer = rescuer;

Admin message