Commit f187a7fd authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

tty: serial: samsung_tty: drop unneded dbg() calls 



Now that the kernel has ftrace, any debugging calls that just do "made
it to this function!" and "leaving this function!" can be removed.

On the quest to move the samsung_tty driver over to use the standard
kernel debugging functions, drop these unneeded calls.

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Hyunki Koo <kkoos00@naver.com>
Cc: HYUN-KI KOO <hyunki00.koo@samsung.com>
Cc: Shinbeom Choi <sbeom.choi@samsung.com>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20191210143706.3928480-6-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 43df170b

drivers/tty/serial/samsung_tty.c

+0 −22
Original line number Diff line number Diff line
@@ -1136,9 +1136,6 @@ static int s3c24xx_serial_startup(struct uart_port *port) 
	struct s3c24xx_uart_port *ourport = to_ourport(port);

	int ret;



	dbg("s3c24xx_serial_startup: port=%p (%08llx,%p)\n",

	    port, (unsigned long long)port->mapbase, port->membase);



	rx_enabled(port) = 1;



	ret = request_irq(ourport->rx_irq, s3c24xx_serial_rx_chars, 0,
@@ -1165,8 +1162,6 @@ static int s3c24xx_serial_startup(struct uart_port *port) 


	ourport->tx_claimed = 1;



	dbg("s3c24xx_serial_startup ok\n");



	/* the port reset code should have done the correct

	 * register setup for the port controls */
@@ -1184,9 +1179,6 @@ static int s3c64xx_serial_startup(struct uart_port *port) 
	unsigned int ufcon;

	int ret;



	dbg("s3c64xx_serial_startup: port=%p (%08llx,%p)\n",

	    port, (unsigned long long)port->mapbase, port->membase);



	wr_regl(port, S3C64XX_UINTM, 0xf);

	if (ourport->dma) {

		ret = s3c24xx_serial_request_dma(ourport);
@@ -1224,7 +1216,6 @@ static int s3c64xx_serial_startup(struct uart_port *port) 
	/* Enable Rx Interrupt */

	s3c24xx_clear_bit(port, S3C64XX_UINTM_RXD, S3C64XX_UINTM);



	dbg("s3c64xx_serial_startup ok\n");

	return ret;

}
@@ -1870,8 +1861,6 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, 
	struct resource *res;

	int ret;



	dbg("s3c24xx_serial_init_port: port=%p, platdev=%p\n", port, platdev);



	if (platdev == NULL)

		return -ENODEV;
@@ -2011,8 +2000,6 @@ static int s3c24xx_serial_probe(struct platform_device *pdev) 
			index = ret;

	}



	dbg("s3c24xx_serial_probe(%p) %d\n", pdev, index);



	if (index >= ARRAY_SIZE(s3c24xx_serial_ports)) {

		dev_err(&pdev->dev, "serial%d out of range\n", index);

		return -EINVAL;
@@ -2273,10 +2260,6 @@ s3c24xx_serial_get_options(struct uart_port *port, int *baud, 
	ucon   = rd_regl(port, S3C2410_UCON);

	ubrdiv = rd_regl(port, S3C2410_UBRDIV);



	dbg("s3c24xx_serial_get_options: port=%p\n"

	    "registers: ulcon=%08x, ucon=%08x, ubdriv=%08x\n",

	    port, ulcon, ucon, ubrdiv);



	if (s3c24xx_port_configured(ucon)) {

		switch (ulcon & S3C2410_LCON_CSMASK) {

		case S3C2410_LCON_CS5:
@@ -2334,9 +2317,6 @@ s3c24xx_serial_console_setup(struct console *co, char *options) 
	int parity = 'n';

	int flow = 'n';



	dbg("s3c24xx_serial_console_setup: co=%p (%d), %s\n",

	    co, co->index, options);



	/* is this a valid port */



	if (co->index == -1 || co->index >= CONFIG_SERIAL_SAMSUNG_UARTS)
@@ -2351,8 +2331,6 @@ s3c24xx_serial_console_setup(struct console *co, char *options) 


	cons_uart = port;



	dbg("s3c24xx_serial_console_setup: port=%p (%d)\n", port, co->index);



	/*

	 * Check whether an invalid uart number has been specified, and

	 * if so, search for the first available port that does have

CRA Git | Maintained and supported by SUSTech CRA and CCSE