Commit f1791425 authored Jan 30, 2014 by Antonio Quartulli

batman-adv: properly check pskb_may_pull return value



pskb_may_pull() returns 1 on success and 0 in case of failure,
therefore checking for the return value being negative does
not make sense at all.

This way if the function fails we will probably read beyond the current
skb data buffer. Fix this by doing the proper check.

Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>

parent 91c2b1a9

net/batman-adv/routing.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -688,7 +688,7 @@ static int batadv_check_unicast_ttvn(struct batadv_priv *bat_priv,
		int is_old_ttvn;

		/* check if there is enough data before accessing it */
		if (pskb_may_pull(skb, hdr_len + ETH_HLEN) < 0)
		if (!pskb_may_pull(skb, hdr_len + ETH_HLEN))
		return 0;

		/* create a copy of the skb (in case of for re-routing) to modify it. */

Admin message