Commit f1689114 authored Oct 07, 2019 by Tadeusz Struk Committed by Jarkko Sakkinen Nov 12, 2019

tpm: add check after commands attribs tab allocation



devm_kcalloc() can fail and return NULL so we need to check for that.

Cc: stable@vger.kernel.org
Fixes: 58472f5c ("tpm: validate TPM 2.0 commands")
Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

parent 1fce4d8a

drivers/char/tpm/tpm2-cmd.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -939,6 +939,10 @@ static int tpm2_get_cc_attrs_tbl(struct tpm_chip *chip)

		chip->cc_attrs_tbl = devm_kcalloc(&chip->dev, 4, nr_commands,
		GFP_KERNEL);
		if (!chip->cc_attrs_tbl) {
		rc = -ENOMEM;
		goto out;
		}

		rc = tpm_buf_init(&buf, TPM2_ST_NO_SESSIONS, TPM2_CC_GET_CAPABILITY);
		if (rc)

Admin message