Commit f15c586d authored Feb 18, 2014 by Ben Dooks Committed by David S. Miller Feb 18, 2014

of_mdio: fix phy interrupt passing



The of_mdiobus_register_phy() is not setting phy->irq thus causing
some drivers to incorrectly assume that the PHY does not have an
IRQ associated with it. Not only do some drivers report no IRQ
they do not install an interrupt handler for the PHY.

Simplify the code setting irq and set the phy->irq at the same
time so that we cover the following issues, which should cover
all the cases the code will find:

- Set phy->irq if node has irq property and mdio->irq is NULL
- Set phy->irq if node has no irq and mdio->irq is not NULL
- Leave phy->irq as PHY_POLL default if none of the above

This fixes the issue:
 net eth0: attached PHY 1 (IRQ -1) to driver Micrel KSZ8041RNLI

to the correct:
 net eth0: attached PHY 1 (IRQ 416) to driver Micrel KSZ8041RNLI

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4b636b53

drivers/of/of_mdio.c

+9 −7

Original line number	Diff line number	Diff line
		@@ -48,7 +48,7 @@ static int of_mdiobus_register_phy(struct mii_bus mdio, struct device_node chi
		{
		struct phy_device *phy;
		bool is_c45;
		int rc, prev_irq;
		int rc;
		u32 max_speed = 0;

		is_c45 = of_device_is_compatible(child,
		@@ -58,12 +58,14 @@ static int of_mdiobus_register_phy(struct mii_bus mdio, struct device_node chi
		if (!phy \|\| IS_ERR(phy))
		return 1;

		if (mdio->irq) {
		prev_irq = mdio->irq[addr];
		mdio->irq[addr] =
		irq_of_parse_and_map(child, 0);
		if (!mdio->irq[addr])
		mdio->irq[addr] = prev_irq;
		rc = irq_of_parse_and_map(child, 0);
		if (rc > 0) {
		phy->irq = rc;
		if (mdio->irq)
		mdio->irq[addr] = rc;
		} else {
		if (mdio->irq)
		phy->irq = mdio->irq[addr];
		}

		/* Associate the OF node with the device structure so it

Admin message