Commit f15480e9 authored Jun 17, 2020 by Christophe JAILLET Committed by Dominik Brodowski Dec 05, 2020

pcmcia/electra_cf: Fix some return values in 'electra_cf_probe()' in case of error



'status' is known to be 0 at this point. It must be set to a meaningful
value in order to return an error code if one of the 'of_get_property()'
call fails.

Return -EINVAL in such a case.

Fixes: 2b571a06("pcmcia: CompactFlash driver for PA Semi Electra boards")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>

parent b3298500

drivers/pcmcia/electra_cf.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -229,6 +229,8 @@ static int electra_cf_probe(struct platform_device *ofdev)

		cf->socket.pci_irq = cf->irq;

		status = -EINVAL;

		prop = of_get_property(np, "card-detect-gpio", NULL);
		if (!prop)
		goto fail1;

Admin message