Unverified Commit f148915f authored Jun 22, 2020 by Krzysztof Kozlowski Committed by Mark Brown Jun 22, 2020

spi: spi-fsl-dspi: Initialize completion before possible interrupt



The interrupt handler calls completion and is IRQ requested before the
completion is initialized.  Logically it should be the other way.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200622110543.5035-4-krzk@kernel.org


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 3d87b613

drivers/spi/spi-fsl-dspi.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1389,6 +1389,8 @@ static int dspi_probe(struct platform_device *pdev)
		goto poll_mode;
		}

		init_completion(&dspi->xfer_done);

		ret = request_threaded_irq(dspi->irq, dspi_interrupt, NULL,
		IRQF_SHARED, pdev->name, dspi);
		if (ret < 0) {
		@@ -1396,8 +1398,6 @@ static int dspi_probe(struct platform_device *pdev)
		goto out_clk_put;
		}

		init_completion(&dspi->xfer_done);

		poll_mode:

		if (dspi->devtype_data->trans_mode == DSPI_DMA_MODE) {

Admin message