Commit f14851af authored Sep 17, 2012 by qiuxishi Committed by Linus Torvalds Sep 17, 2012

memory hotplug: fix section info double registration bug



There may be a bug when registering section info.  For example, on my
Itanium platform, the pfn range of node0 includes the other nodes, so
other nodes' section info will be double registered, and memmap's page
count will equal to 3.

  node0: start_pfn=0x100,    spanned_pfn=0x20fb00, present_pfn=0x7f8a3, => 0x000100-0x20fc00
  node1: start_pfn=0x80000,  spanned_pfn=0x80000,  present_pfn=0x80000, => 0x080000-0x100000
  node2: start_pfn=0x100000, spanned_pfn=0x80000,  present_pfn=0x80000, => 0x100000-0x180000
  node3: start_pfn=0x180000, spanned_pfn=0x80000,  present_pfn=0x80000, => 0x180000-0x200000

  free_all_bootmem_node()
	register_page_bootmem_info_node()
		register_page_bootmem_info_section()

When hot remove memory, we can't free the memmap's page because
page_count() is 2 after put_page_bootmem().

  sparse_remove_one_section()
	free_section_usemap()
		free_map_bootmem()
			put_page_bootmem()

[akpm@linux-foundation.org: add code comment]
Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Acked-by: Mel Gorman <mgorman@suse.de>
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0ba8f2d5

mm/memory_hotplug.c

+10 −6

Original line number	Diff line number	Diff line
		@@ -126,9 +126,6 @@ static void register_page_bootmem_info_section(unsigned long start_pfn)
		struct mem_section *ms;
		struct page page, memmap;

		if (!pfn_valid(start_pfn))
		return;

		section_nr = pfn_to_section_nr(start_pfn);
		ms = __nr_to_section(section_nr);

		@@ -187,9 +184,16 @@ void register_page_bootmem_info_node(struct pglist_data *pgdat)
		end_pfn = pfn + pgdat->node_spanned_pages;

		/* register_section info */
		for (; pfn < end_pfn; pfn += PAGES_PER_SECTION)
		for (; pfn < end_pfn; pfn += PAGES_PER_SECTION) {
		/*
		* Some platforms can assign the same pfn to multiple nodes - on
		* node0 as well as nodeN. To avoid registering a pfn against
		* multiple nodes we check that this pfn does not already
		* reside in some other node.
		*/
		if (pfn_valid(pfn) && (pfn_to_nid(pfn) == node))
		register_page_bootmem_info_section(pfn);

		}
		}
		#endif /* !CONFIG_SPARSEMEM_VMEMMAP */

Admin message