Commit f12fb284 authored May 28, 2019 by Lubomir Rintel Committed by Mauro Carvalho Chehab Jun 24, 2019

media: marvell-ccic/mmp: enable clock before accessing registers



The access to REG_CLKCTRL or REG_CTRL1 without the clock enabled hangs
the machine. Enable the clock first.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent fa49e1d3

drivers/media/platform/marvell-ccic/mmp-driver.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -142,6 +142,7 @@ static int mmpcam_power_up(struct mcam_camera *mcam)
		* Turn on power and clocks to the controller.
		*/
		mmpcam_power_up_ctlr(cam);
		mcam_clk_enable(mcam);
		/*
		* Provide power to the sensor.
		*/
		@@ -155,8 +156,6 @@ static int mmpcam_power_up(struct mcam_camera *mcam)
		gpio_set_value(pdata->sensor_reset_gpio, 1); /* reset is active low */
		mdelay(5);

		mcam_clk_enable(mcam);

		return 0;
		}

Admin message