Commit f1267cf3 authored Apr 16, 2019 by Bhagavathi Perumal S Committed by Johannes Berg Apr 23, 2019

mac80211: Fix kernel panic due to use of txq after free



The txq of vif is added to active_txqs list for ATF TXQ scheduling
in the function ieee80211_queue_skb(), but it was not properly removed
before freeing the txq object. It was causing use after free of the txq
objects from the active_txqs list, result was kernel panic
due to invalid memory access.

Fix kernel invalid memory access by properly removing txq object
from active_txqs list before free the object.

Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent e9f33a8f

net/mac80211/iface.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1908,6 +1908,9 @@ void ieee80211_if_remove(struct ieee80211_sub_if_data *sdata)
		list_del_rcu(&sdata->list);
		mutex_unlock(&sdata->local->iflist_mtx);

		if (sdata->vif.txq)
		ieee80211_txq_purge(sdata->local, to_txq_info(sdata->vif.txq));

		synchronize_rcu();

		if (sdata->dev) {

Admin message