mfd: madera: Simplify with dev_err_probe() (f104563f) · Commits · 戴 / test

Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by:

drivers/mfd/madera-core.c

+3 −8

Original line number	Diff line number	Diff line
		@@ -369,19 +369,14 @@ EXPORT_SYMBOL_GPL(madera_of_match);
		static int madera_get_reset_gpio(struct madera *madera)
		{
		struct gpio_desc *reset;
		int ret;

		if (madera->pdata.reset)
		return 0;

		reset = devm_gpiod_get_optional(madera->dev, "reset", GPIOD_OUT_LOW);
		if (IS_ERR(reset)) {
		ret = PTR_ERR(reset);
		if (ret != -EPROBE_DEFER)
		dev_err(madera->dev, "Failed to request /RESET: %d\n",
		ret);
		return ret;
		}
		if (IS_ERR(reset))
		return dev_err_probe(madera->dev, PTR_ERR(reset),
		"Failed to request /RESET");

		/*
		* A hard reset is needed for full reset of the chip. We allow running