Commit f0fcf9ad authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Herbert Xu
Browse files

crypto: qat - no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Conor McLoughlin <conor.mcloughlin@intel.com>
Cc: Waiman Long <longman@redhat.com>
Cc: qat-linux@intel.com
Cc: linux-crypto@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 763069ba

drivers/crypto/qat/qat_c3xxx/adf_drv.c

+0 −5
Original line number Diff line number Diff line
@@ -193,11 +193,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
		 PCI_FUNC(pdev->devfn));



	accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);

	if (!accel_dev->debugfs_dir) {

		dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);

		ret = -EINVAL;

		goto out_err;

	}



	/* Create device configuration table */

	ret = adf_cfg_dev_add(accel_dev);

drivers/crypto/qat/qat_c3xxxvf/adf_drv.c

+0 −5
Original line number Diff line number Diff line
@@ -177,11 +177,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
		 PCI_FUNC(pdev->devfn));



	accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);

	if (!accel_dev->debugfs_dir) {

		dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);

		ret = -EINVAL;

		goto out_err;

	}



	/* Create device configuration table */

	ret = adf_cfg_dev_add(accel_dev);

drivers/crypto/qat/qat_c62x/adf_drv.c

+0 −5
Original line number Diff line number Diff line
@@ -193,11 +193,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
		 PCI_FUNC(pdev->devfn));



	accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);

	if (!accel_dev->debugfs_dir) {

		dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);

		ret = -EINVAL;

		goto out_err;

	}



	/* Create device configuration table */

	ret = adf_cfg_dev_add(accel_dev);

drivers/crypto/qat/qat_c62xvf/adf_drv.c

+0 −5
Original line number Diff line number Diff line
@@ -177,11 +177,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
		 PCI_FUNC(pdev->devfn));



	accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);

	if (!accel_dev->debugfs_dir) {

		dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);

		ret = -EINVAL;

		goto out_err;

	}



	/* Create device configuration table */

	ret = adf_cfg_dev_add(accel_dev);

drivers/crypto/qat/qat_common/adf_cfg.c

+0 −7
Original line number Diff line number Diff line
@@ -141,13 +141,6 @@ int adf_cfg_dev_add(struct adf_accel_dev *accel_dev) 
						  accel_dev->debugfs_dir,

						  dev_cfg_data,

						  &qat_dev_cfg_fops);

	if (!dev_cfg_data->debug) {

		dev_err(&GET_DEV(accel_dev),

			"Failed to create qat cfg debugfs entry.\n");

		kfree(dev_cfg_data);

		accel_dev->cfg = NULL;

		return -EFAULT;

	}

	return 0;

}

EXPORT_SYMBOL_GPL(adf_cfg_dev_add);

CRA Git | Maintained and supported by SUSTech CRA and CCSE