Commit f0f70adb authored by Peter Zijlstra's avatar Peter Zijlstra
Browse files

objtool: Rename func_for_each_insn_all() 



Now that func_for_each_insn() is available, rename
func_for_each_insn_all(). This gets us:

  sym_for_each_insn()  - iterate on symbol offset/len
  func_for_each_insn() - iterate on insn->func

Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarMiroslav Benes <mbenes@suse.cz>
Acked-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
Link: https://lkml.kernel.org/r/20200324160924.083720147@infradead.org
parent dbf4aeb0

tools/objtool/check.c

+6 −6
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ static struct instruction *next_insn_same_func(struct objtool_file *file, 
	return find_insn(file, func->cfunc->sec, func->cfunc->offset);

}



#define func_for_each_insn_all(file, func, insn)			\

#define func_for_each_insn(file, func, insn)				\

	for (insn = find_insn(file, func->sec, func->offset);		\

	     insn;							\

	     insn = next_insn_same_func(file, insn))
@@ -170,7 +170,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, 
	if (!insn->func)

		return false;



	func_for_each_insn_all(file, func, insn) {

	func_for_each_insn(file, func, insn) {

		empty = false;



		if (insn->type == INSN_RETURN)
@@ -185,7 +185,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, 
	 * case, the function's dead-end status depends on whether the target

	 * of the sibling call returns.

	 */

	func_for_each_insn_all(file, func, insn) {

	func_for_each_insn(file, func, insn) {

		if (is_sibling_call(insn)) {

			struct instruction *dest = insn->jump_dest;
@@ -430,7 +430,7 @@ static void add_ignores(struct objtool_file *file) 
			continue;

		}



		func_for_each_insn_all(file, func, insn)

		func_for_each_insn(file, func, insn)

			insn->ignore = true;

	}

}
@@ -1122,7 +1122,7 @@ static void mark_func_jump_tables(struct objtool_file *file, 
	struct instruction *insn, *last = NULL;

	struct rela *rela;



	func_for_each_insn_all(file, func, insn) {

	func_for_each_insn(file, func, insn) {

		if (!last)

			last = insn;
@@ -1157,7 +1157,7 @@ static int add_func_jump_tables(struct objtool_file *file, 
	struct instruction *insn;

	int ret;



	func_for_each_insn_all(file, func, insn) {

	func_for_each_insn(file, func, insn) {

		if (!insn->jump_table)

			continue;

CRA Git | Maintained and supported by SUSTech CRA and CCSE