Commit f0f3a6ce authored Dec 17, 2019 by Tvrtko Ursulin Committed by Joonas Lahtinen Dec 18, 2019

drm/i915: Fix pid leak with banned clients



Get_pid_task() needs to be paired with a put_pid or we leak a pid
reference every time a banned client tries to create a context.

v2:
 * task_pid_nr helper exists! (Chris)

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: b083a087 ("drm/i915: Add per client max context ban limit")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20191217170933.8108-1-tvrtko.ursulin@linux.intel.com


(cherry picked from commit ba16a48a)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

parent a76cf569

drivers/gpu/drm/i915/gem/i915_gem_context.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2167,8 +2167,7 @@ int i915_gem_context_create_ioctl(struct drm_device dev, void data,
		ext_data.fpriv = file->driver_priv;
		if (client_is_banned(ext_data.fpriv)) {
		DRM_DEBUG("client %s[%d] banned from creating ctx\n",
		current->comm,
		pid_nr(get_task_pid(current, PIDTYPE_PID)));
		current->comm, task_pid_nr(current));
		return -EIO;
		}

Admin message