Commit f0e1266e authored by Amir Goldstein's avatar Amir Goldstein Committed by Miklos Szeredi
Browse files

ovl: fix mount option checks for nfs_export with no upperdir 



Without upperdir mount option, there is no index dir and the dependency
checks nfs_export => index for mount options parsing are incorrect.

Allow the combination nfs_export=on,index=off with no upperdir and move
the check for dependency redirect_dir=nofollow for non-upper mount case
to mount options parsing.

Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 470c1563

Documentation/filesystems/overlayfs.rst

+2 −2
Original line number Diff line number Diff line
@@ -560,8 +560,8 @@ When the NFS export feature is enabled, all directory index entries are 
verified on mount time to check that upper file handles are not stale.

This verification may cause significant overhead in some cases.



Note: the mount options index=off,nfs_export=on are conflicting and will

result in an error.

Note: the mount options index=off,nfs_export=on are conflicting for a

read-write mount and will result in an error.





Testsuite

fs/overlayfs/super.c

+18 −13
Original line number Diff line number Diff line
@@ -580,13 +580,20 @@ static int ovl_parse_opt(char *opt, struct ovl_config *config) 
		}

	}



	/* Workdir is useless in non-upper mount */

	if (!config->upperdir && config->workdir) {

	/* Workdir/index are useless in non-upper mount */

	if (!config->upperdir) {

		if (config->workdir) {

			pr_info("option \"workdir=%s\" is useless in a non-upper mount, ignore\n",

				config->workdir);

			kfree(config->workdir);

			config->workdir = NULL;

		}

		if (config->index && index_opt) {

			pr_info("option \"index=on\" is useless in a non-upper mount, ignore\n");

			index_opt = false;

		}

		config->index = false;

	}



	err = ovl_parse_redirect_mode(config, config->redirect_mode);

	if (err)
@@ -622,11 +629,13 @@ static int ovl_parse_opt(char *opt, struct ovl_config *config) 


	/* Resolve nfs_export -> index dependency */

	if (config->nfs_export && !config->index) {

		if (nfs_export_opt && index_opt) {

		if (!config->upperdir && config->redirect_follow) {

			pr_info("NFS export requires \"redirect_dir=nofollow\" on non-upper mount, falling back to nfs_export=off.\n");

			config->nfs_export = false;

		} else if (nfs_export_opt && index_opt) {

			pr_err("conflicting options: nfs_export=on,index=off\n");

			return -EINVAL;

		}

		if (index_opt) {

		} else if (index_opt) {

			/*

			 * There was an explicit index=off that resulted

			 * in this conflict.
@@ -1603,10 +1612,6 @@ static struct ovl_entry *ovl_get_lowerstack(struct super_block *sb, 
	if (!ofs->config.upperdir && numlower == 1) {

		pr_err("at least 2 lowerdir are needed while upperdir nonexistent\n");

		return ERR_PTR(-EINVAL);

	} else if (!ofs->config.upperdir && ofs->config.nfs_export &&

		   ofs->config.redirect_follow) {

		pr_warn("NFS export requires \"redirect_dir=nofollow\" on non-upper mount, falling back to nfs_export=off.\n");

		ofs->config.nfs_export = false;

	}



	stack = kcalloc(numlower, sizeof(struct path), GFP_KERNEL);

CRA Git | Maintained and supported by SUSTech CRA and CCSE