Commit f0df462f authored Dec 18, 2018 by Uwe Kleine-König Committed by Linus Walleij Dec 21, 2018

gpio: mxs: read pin level directly instead of using .get

Calling readl directly instead of going through another function that
results in the same result to remove some overhead. I didn't try to
measure the performance gain, but IMHO there is little benefit from
abstracting a GPIO register access in the GPIO driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 533918b6

drivers/gpio/gpio-mxs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -84,7 +84,7 @@ static int mxs_gpio_set_irq_type(struct irq_data *d, unsigned int type)
		port->both_edges &= ~pin_mask;
		switch (type) {
		case IRQ_TYPE_EDGE_BOTH:
		val = port->gc.get(&port->gc, d->hwirq);
		val = readl(port->base + PINCTRL_DIN(port)) & pin_mask;
		if (val)
		edge = GPIO_INT_FALL_EDGE;
		else

Admin message