Unverified Commit f0df2e65 authored Jan 08, 2020 by Wei Yongjun Committed by Mark Brown Jan 09, 2020

ASoC: amd: acp3x: Fix return value check in acp3x_dai_probe()



In case of error, the function devm_ioremap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: c9fe7db6 ("ASoC: amd: Refactoring of DAI from DMA driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200108035954.51317-1-weiyongjun1@huawei.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 599b1019

sound/soc/amd/raven/acp3x-i2s.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -321,8 +321,8 @@ static int acp3x_dai_probe(struct platform_device *pdev)
		}
		adata->acp3x_base = devm_ioremap(&pdev->dev, res->start,
		resource_size(res));
		if (IS_ERR(adata->acp3x_base))
		return PTR_ERR(adata->acp3x_base);
		if (!adata->acp3x_base)
		return -ENOMEM;

		adata->i2s_irq = res->start;
		dev_set_drvdata(&pdev->dev, adata);

Admin message