Commit f0d532c4 authored Oct 24, 2019 by Michal Vokáč Committed by David S. Miller Oct 28, 2019

net: dsa: qca8k: Initialize the switch with correct number of ports



Since commit 0394a63a ("net: dsa: enable and disable all ports")
the dsa core disables all unused ports of a switch. In this case
disabling ports with numbers higher than QCA8K_NUM_PORTS causes that
some switch registers are overwritten with incorrect content.

To fix this, initialize the dsa_switch->num_ports with correct number
of ports.

Fixes: 7e99e347 ("net: dsa: remove dsa_switch_alloc helper")
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 556f124f

drivers/net/dsa/qca8k.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1083,7 +1083,7 @@ qca8k_sw_probe(struct mdio_device *mdiodev)
		return -ENOMEM;

		priv->ds->dev = &mdiodev->dev;
		priv->ds->num_ports = DSA_MAX_PORTS;
		priv->ds->num_ports = QCA8K_NUM_PORTS;
		priv->ds->priv = priv;
		priv->ops = qca8k_switch_ops;
		priv->ds->ops = &priv->ops;

Admin message