Commit f0cf973a authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt
Browse files

ftrace: Return record ip addr for ftrace_location() 



ftrace_location() is passed an addr, and returns 1 if the addr is
on a ftrace nop (or caller to ftrace_caller), and 0 otherwise.

To let kprobes know if it should move a breakpoint or not, it
must return the actual addr that is the start of the ftrace nop.
This way a kprobe placed on the location of a ftrace nop, can
instead be placed on the instruction after the nop. Even if the
probe addr is on the second or later byte of the nop, it can
simply be moved forward.

Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent a650e02a

include/linux/ftrace.h

+1 −1
Original line number Diff line number Diff line
@@ -295,7 +295,7 @@ struct dyn_ftrace *ftrace_rec_iter_record(struct ftrace_rec_iter *iter); 
int ftrace_update_record(struct dyn_ftrace *rec, int enable);

int ftrace_test_record(struct dyn_ftrace *rec, int enable);

void ftrace_run_stop_machine(int command);

int ftrace_location(unsigned long ip);

unsigned long ftrace_location(unsigned long ip);



extern ftrace_func_t ftrace_trace_function;

kernel/trace/ftrace.c

+10 −6
Original line number Diff line number Diff line
@@ -1393,7 +1393,7 @@ static int ftrace_cmp_recs(const void *a, const void *b) 
	return 0;

}



static int ftrace_location_range(unsigned long start, unsigned long end)

static unsigned long ftrace_location_range(unsigned long start, unsigned long end)

{

	struct ftrace_page *pg;

	struct dyn_ftrace *rec;
@@ -1410,7 +1410,7 @@ static int ftrace_location_range(unsigned long start, unsigned long end) 
			      sizeof(struct dyn_ftrace),

			      ftrace_cmp_recs);

		if (rec)

			return 1;

			return rec->ip;

	}



	return 0;
@@ -1420,12 +1420,12 @@ static int ftrace_location_range(unsigned long start, unsigned long end) 
 * ftrace_location - return true if the ip giving is a traced location

 * @ip: the instruction pointer to check

 *

 * Returns 1 if @ip given is a pointer to a ftrace location.

 * Returns rec->ip if @ip given is a pointer to a ftrace location.

 * That is, the instruction that is either a NOP or call to

 * the function tracer. It checks the ftrace internal tables to

 * determine if the address belongs or not.

 */

int ftrace_location(unsigned long ip)

unsigned long ftrace_location(unsigned long ip)

{

	return ftrace_location_range(ip, ip);

}
@@ -1442,8 +1442,12 @@ int ftrace_location(unsigned long ip) 
 */

int ftrace_text_reserved(void *start, void *end)

{

	return ftrace_location_range((unsigned long)start,

	unsigned long ret;



	ret = ftrace_location_range((unsigned long)start,

				    (unsigned long)end);



	return (int)!!ret;

}



static void __ftrace_hash_rec_update(struct ftrace_ops *ops,

CRA Git | Maintained and supported by SUSTech CRA and CCSE