Commit f0bf0bd0 authored Feb 27, 2015 by Jiri Slaby Committed by Greg Kroah-Hartman Mar 07, 2015

tty: fix up atime/mtime mess, take four



This problem was taken care of three times already in
* b0de59b5 (TTY: do not update
  atime/mtime on read/write),
* 37b7f3c7 (TTY: fix atime/mtime
  regression), and
* b0b88565 (tty: fix up atime/mtime
  mess, take three)

But it still misses one point. As John Paul correctly points out, we
do not care about setting date. If somebody ever changes wall
time backwards (by mistake for example), tty timestamps are never
updated until the original wall time passes.

So check the absolute difference of times and if it large than "8
seconds or so", always update the time. That means we will update
immediatelly when changing time. Ergo, CAP_SYS_TIME can foul the
check, but it was always that way.

Thanks John for serving me this so nicely debugged.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: John Paul Perry <john_paul.perry@alcatel-lucent.com>
Cc: <stable@vger.kernel.org> # all, as b0b88565 was backported
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent dfd37668

drivers/tty/tty_io.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1028,8 +1028,8 @@ EXPORT_SYMBOL(start_tty);
		/* We limit tty time update visibility to every 8 seconds or so. */
		static void tty_update_time(struct timespec *time)
		{
		unsigned long sec = get_seconds() & ~7;
		if ((long)(sec - time->tv_sec) > 0)
		unsigned long sec = get_seconds();
		if (abs(sec - time->tv_sec) & ~7)
		time->tv_sec = sec;
		}

Admin message