Commit f04e2be7 authored by Larry Finger's avatar Larry Finger Committed by Jeff Garzik
Browse files

[PATCH] bcm43xx: output proper link quality with scans 



The bcm43xx-softmac driver fails to set two quantities needed for
iwlist to compute wireless quality when scanning. As a result, userland
programs using the quality to determine the best connection fail.

Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 3470cb1d

drivers/net/wireless/bcm43xx/bcm43xx.h

+3 −0
Original line number Diff line number Diff line
@@ -365,6 +365,9 @@ 
#define BCM43xx_DEFAULT_SHORT_RETRY_LIMIT	7

#define BCM43xx_DEFAULT_LONG_RETRY_LIMIT	4



/* FIXME: the next line is a guess as to what the maximum RSSI value might be */

#define RX_RSSI_MAX				60



/* Max size of a security key */

#define BCM43xx_SEC_KEYSIZE			16

/* Security algorithms. */

drivers/net/wireless/bcm43xx/bcm43xx_main.c

+2 −0
Original line number Diff line number Diff line
@@ -3688,6 +3688,8 @@ static int bcm43xx_read_phyinfo(struct bcm43xx_private *bcm) 
		       phy_type);

		return -ENODEV;

	};

	bcm->ieee->perfect_rssi = RX_RSSI_MAX;

	bcm->ieee->worst_rssi = 0;

	if (!phy_rev_ok) {

		printk(KERN_WARNING PFX "Invalid PHY Revision %x\n",

		       phy_rev);

drivers/net/wireless/bcm43xx/bcm43xx_wx.c

+0 −3
Original line number Diff line number Diff line
@@ -47,9 +47,6 @@ 
#define BCM43xx_WX_VERSION	18



#define MAX_WX_STRING		80

/* FIXME: the next line is a guess as to what the maximum RSSI value might be */

#define RX_RSSI_MAX		60





static int bcm43xx_wx_get_name(struct net_device *net_dev,

                               struct iw_request_info *info,

CRA Git | Maintained and supported by SUSTech CRA and CCSE