Commit f0454029 authored Jul 07, 2016 by David Hildenbrand Committed by Martin Schwidefsky Jul 13, 2016

s390/mm: fix gmap tlb flush issues



__tlb_flush_asce() should never be used if multiple asce belong to a mm.

As this function changes mm logic determining if local or global tlb
flushes will be neded, we might end up flushing only the gmap asce on all
CPUs and a follow up mm asce flushes will only flush on the local CPU,
although that asce ran on multiple CPUs.

The missing tlb flushes will provoke strange faults in user space and even
low address protections in user space, crashing the kernel.

Fixes: 1b948d6c ("s390/mm,tlb: optimize TLB flushing for zEC12")
Cc: stable@vger.kernel.org # 3.15+
Reported-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

parent d08de8e2

arch/s390/include/asm/tlbflush.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -74,7 +74,8 @@ static inline void __tlb_flush_full(struct mm_struct *mm)
		}

		/*
		* Flush TLB entries for a specific ASCE on all CPUs.
		* Flush TLB entries for a specific ASCE on all CPUs. Should never be used
		* when more than one asce (e.g. gmap) ran on this mm.
		*/
		static inline void __tlb_flush_asce(struct mm_struct *mm, unsigned long asce)
		{

arch/s390/mm/gmap.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -85,7 +85,7 @@ EXPORT_SYMBOL_GPL(gmap_alloc);
		static void gmap_flush_tlb(struct gmap *gmap)
		{
		if (MACHINE_HAS_IDTE)
		__tlb_flush_asce(gmap->mm, gmap->asce);
		__tlb_flush_idte(gmap->asce);
		else
		__tlb_flush_global();
		}
		@@ -124,7 +124,7 @@ void gmap_free(struct gmap *gmap)

		/* Flush tlb. */
		if (MACHINE_HAS_IDTE)
		__tlb_flush_asce(gmap->mm, gmap->asce);
		__tlb_flush_idte(gmap->asce);
		else
		__tlb_flush_global();

Admin message