Commit f044baaf authored May 15, 2020 by Bjorn Helgaas

PCI/PM: Adjust pcie_wait_for_link_delay() for caller delay



The caller of pcie_wait_for_link_delay() specifies the time to wait after
the link becomes active.  When the downstream port doesn't support link
active reporting, obviously we can't tell when the link becomes active, so
we waited the worst-case time (1000 ms) plus 100 ms, ignoring the delay
from the caller.

Instead, wait for 1000 ms + the delay from the caller.

Fixes: 4827d638 ("PCI/PM: Add pcie_wait_for_link_delay()")
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent 68f5fc4e

drivers/pci/pci.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -4675,10 +4675,10 @@ static bool pcie_wait_for_link_delay(struct pci_dev *pdev, bool active,

		/*
		* Some controllers might not implement link active reporting. In this
		* case, we wait for 1000 + 100 ms.
		* case, we wait for 1000 ms + any delay requested by the caller.
		*/
		if (!pdev->link_active_reporting) {
		msleep(1100);
		msleep(timeout + delay);
		return true;
		}

Admin message