Commit f02fba3a authored May 03, 2019 by Bjorn Andersson Committed by Stephen Boyd Jun 07, 2019

clk: qcom: gdsc: WARN when failing to toggle



Failing to toggle a GDSC as the driver core is attaching the
power-domain to a device will cause a silent probe deferral. Provide an
explicit warning to the developer, in order to reduce the amount of time
it takes to debug this.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org>
Tested-by: Jeffrey Hugo <jhugo@codeaurora.org>
Reviewed-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent a188339c

drivers/clk/qcom/gdsc.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -149,7 +149,9 @@ static int gdsc_toggle_logic(struct gdsc *sc, enum gdsc_status status)
		udelay(1);
		}

		return gdsc_poll_status(sc, status);
		ret = gdsc_poll_status(sc, status);
		WARN(ret, "%s status stuck at 'o%s'", sc->pd.name, status ? "ff" : "n");
		return ret;
		}

		static inline int gdsc_deassert_reset(struct gdsc *sc)

Admin message