Commit f02cec9d authored Mar 30, 2020 by Trond Myklebust

NFS: Fix a request reference leak in nfs_direct_write_clear_reqs()

nfs_direct_write_scan_commit_list() will lock the request and bump
the reference count, but we also need to account for the reference
that was taken when we initially added the request to the commit list.

Fixes: fb5f7f20 ("NFS: commit errors should be fatal")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

parent dc9dc2fe

fs/nfs/direct.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -646,6 +646,7 @@ static void nfs_direct_write_clear_reqs(struct nfs_direct_req *dreq)
		while (!list_empty(&reqs)) {
		req = nfs_list_entry(reqs.next);
		nfs_list_remove_request(req);
		nfs_release_request(req);
		nfs_unlock_and_release_request(req);
		}
		}

Admin message