RDS: use gfp flags from caller in conn_alloc() (f0229eaa) · Commits · 戴 / test

We should be using the gfp flags the caller specified here, instead of GFP_KERNEL. I think this might be a bugfix, depending on the value of "sock->sk->sk_allocation" when we call rds_conn_create_outgoing() in rds_sendmsg(). Otherwise, it's just a cleanup. Signed-off-by:

Dan Carpenter <dan.carpenter@oracle.com> Acked-by:

Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/rds/ib_cm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -749,7 +749,7 @@ int rds_ib_conn_alloc(struct rds_connection *conn, gfp_t gfp)
		int ret;

		/* XXX too lazy? */
		ic = kzalloc(sizeof(struct rds_ib_connection), GFP_KERNEL);
		ic = kzalloc(sizeof(struct rds_ib_connection), gfp);
		if (!ic)
		return -ENOMEM;

net/rds/iw_cm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -694,7 +694,7 @@ int rds_iw_conn_alloc(struct rds_connection *conn, gfp_t gfp)
		unsigned long flags;

		/* XXX too lazy? */
		ic = kzalloc(sizeof(struct rds_iw_connection), GFP_KERNEL);
		ic = kzalloc(sizeof(struct rds_iw_connection), gfp);
		if (!ic)
		return -ENOMEM;

net/rds/loop.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -121,7 +121,7 @@ static int rds_loop_conn_alloc(struct rds_connection *conn, gfp_t gfp)
		struct rds_loop_connection *lc;
		unsigned long flags;

		lc = kzalloc(sizeof(struct rds_loop_connection), GFP_KERNEL);
		lc = kzalloc(sizeof(struct rds_loop_connection), gfp);
		if (!lc)
		return -ENOMEM;

Admin message