Commit f01d1d54 authored Feb 06, 2009 by Alexey Dobriyan Committed by Linus Torvalds Feb 05, 2009

seq_file: fix big-enough lseek() + read()



lseek() further than length of the file will leave stale ->index
(second-to-last during iteration). Next seq_read() will not notice
that ->f_pos is big enough to return 0, but will print last item
as if ->f_pos is pointing to it.

Introduced in commit cb510b81
aka "seq_file: more atomicity in traverse()".

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 33da8892

fs/seq_file.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -102,6 +102,7 @@ static int traverse(struct seq_file *m, loff_t offset)
		p = m->op->next(m, p, &index);
		}
		m->op->stop(m, p);
		m->index = index;
		return error;

		Eoverflow:

Admin message