Commit f014ffb0 authored Oct 12, 2018 by David Howells Committed by Greg Kroah-Hartman Oct 12, 2018

afs: Fix afs_server struct leak



Fix a leak of afs_server structs.  The routine that installs them in the
various lookup lists and trees gets a ref on leaving the function, whether
it added the server or a server already exists.  It shouldn't increment
the refcount if it added the server.

The effect of this that "rmmod kafs" will hang waiting for the leaked
server to become unused.

Fixes: d2ddc776 ("afs: Overhaul volume and server record caching and fileserver rotation")
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b40afc00

fs/afs/server.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -199,9 +199,11 @@ static struct afs_server afs_install_server(struct afs_net net,

		write_sequnlock(&net->fs_addr_lock);
		ret = 0;
		goto out;

		exists:
		afs_get_server(server);
		out:
		write_sequnlock(&net->fs_lock);
		return server;
		}

Admin message