Commit effcea16 authored by Emmanuel Grumbach's avatar Emmanuel Grumbach Committed by John W. Linville
Browse files

iwlagn: fix the check of IWLAGN_FIRST_AMPDU_QUEUE 



BUILD_BUG_ON(ARRAY_SIZE(iwlagn_ipan_queue_to_tx_fifo) !=
						IWLAGN_FIRST_AMPDU_QUEUE);

This check can be buggy. IWLAGN_FIRST_AMPDU_QUEUE has to be greater than the
ARRAY_SIZE of iwlagn_ipan_queue_to_tx_fifo.

Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 105183b1

drivers/net/wireless/iwlwifi/iwl-trans.c

+2 −2
Original line number Diff line number Diff line
@@ -875,9 +875,9 @@ static void iwl_trans_pcie_tx_start(struct iwl_priv *priv) 
	/* reset to 0 to enable all the queue first */

	priv->txq_ctx_active_msk = 0;



	BUILD_BUG_ON(ARRAY_SIZE(iwlagn_default_queue_to_tx_fifo) !=

	BUILD_BUG_ON(ARRAY_SIZE(iwlagn_default_queue_to_tx_fifo) <

						IWLAGN_FIRST_AMPDU_QUEUE);

	BUILD_BUG_ON(ARRAY_SIZE(iwlagn_ipan_queue_to_tx_fifo) !=

	BUILD_BUG_ON(ARRAY_SIZE(iwlagn_ipan_queue_to_tx_fifo) <

						IWLAGN_FIRST_AMPDU_QUEUE);



	for (i = 0; i < IWLAGN_FIRST_AMPDU_QUEUE; i++) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE