Commit eff06bd5 authored Sep 21, 2020 by Xu Wang Committed by Stephen Boyd Oct 13, 2020

clk: clk-prima2: fix return value check in prima2_clk_init()



In case of error, the function clk_register() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Link: https://lore.kernel.org/r/20200921034522.9077-1-vulab@iscas.ac.cn


Acked-by: Barry Song <baohua@kernel.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 9123e3a7

drivers/clk/sirf/clk-prima2.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -134,7 +134,7 @@ static void __init prima2_clk_init(struct device_node *np)

		for (i = pll1; i < maxclk; i++) {
		prima2_clks[i] = clk_register(NULL, prima2_clk_hw_array[i]);
		BUG_ON(!prima2_clks[i]);
		BUG_ON(IS_ERR(prima2_clks[i]));
		}
		clk_register_clkdev(prima2_clks[cpu], NULL, "cpu");
		clk_register_clkdev(prima2_clks[io], NULL, "io");

Admin message