Commit efe771c7 authored Mar 05, 2019 by Mel Gorman Committed by Linus Torvalds Mar 05, 2019

mm, compaction: always finish scanning of a full pageblock

When compaction is finishing, it uses a flag to ensure the pageblock is
complete but it makes sense to always complete migration of a pageblock.
Minimally, skip information is based on a pageblock and partially
scanned pageblocks may incur more scanning in the future.  The pageblock
skip handling also becomes more strict later in the series and the hint
is more useful if a complete pageblock was always scanned.

The potentially impacts latency as more scanning is done but it's not a
consistent win or loss as the scanning is not always a high percentage
of the pageblock and sometimes it is offset by future reductions in
scanning.  Hence, the results are not presented this time due to a
misleading mix of gains/losses without any clear pattern.  However, full
scanning of the pageblock is important for later patches.

Link: http://lkml.kernel.org/r/20190118175136.31341-8-mgorman@techsingularity.net


Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Rientjes <rientjes@google.com>
Cc: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 806031bb

mm/compaction.c

+8 −11

Original line number	Diff line number	Diff line
		@@ -1331,16 +1331,14 @@ static enum compact_result __compact_finished(struct compact_control *cc)
		if (is_via_compact_memory(cc->order))
		return COMPACT_CONTINUE;

		if (cc->finishing_block) {
		/*
		* We have finished the pageblock, but better check again that
		* we really succeeded.
		* Always finish scanning a pageblock to reduce the possibility of
		* fallbacks in the future. This is particularly important when
		* migration source is unmovable/reclaimable but it's not worth
		* special casing.
		*/
		if (IS_ALIGNED(cc->migrate_pfn, pageblock_nr_pages))
		cc->finishing_block = false;
		else
		if (!IS_ALIGNED(cc->migrate_pfn, pageblock_nr_pages))
		return COMPACT_CONTINUE;
		}

		/* Direct compactor: Is a suitable page free? */
		for (order = cc->order; order < MAX_ORDER; order++) {
		@@ -1382,7 +1380,6 @@ static enum compact_result __compact_finished(struct compact_control *cc)
		return COMPACT_SUCCESS;
		}

		cc->finishing_block = true;
		return COMPACT_CONTINUE;
		}
		}

mm/internal.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -203,7 +203,6 @@ struct compact_control {
		bool direct_compaction; /* False from kcompactd or /proc/... */
		bool whole_zone; /* Whole zone should/has been scanned */
		bool contended; /* Signal lock or sched contention */
		bool finishing_block; /* Finishing current pageblock */
		};

		unsigned long

Admin message