Commit efd049fb authored by Josef Bacik's avatar Josef Bacik Committed by Chris Mason
Browse files

Btrfs: do not try and lookup the file extent when finishing ordered io 



When running the following fio job

[torrent]
filename=torrent-test
rw=randwrite
size=4g
filesize=4g
bs=4k
ioengine=sync

you would see long stalls where no work was being done.  That is because we were
doing all this extra work to read in the file extent outside of the transaction,
however in the random io case this ends up hurting us because the file extents
are not there to begin with.  So axe this logic, since we end up reading in the
file extent when we go to update it anyway.  This took the fio job from 11 mb/s
with several ~10 second stalls to 24 mb/s to a couple of 1-2 second stalls.

Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
parent 7a7965f8

fs/btrfs/inode.c

+2 −44
Original line number Original line Diff line number Diff line
@@ -1681,24 +1681,6 @@ static int insert_reserved_file_extent(struct btrfs_trans_handle *trans, 
 * before we start the transaction.  It limits the amount of btree

 * before we start the transaction.  It limits the amount of btree

 * reads required while inside the transaction.

 * reads required while inside the transaction.

 */

 */

static noinline void reada_csum(struct btrfs_root *root,

				struct btrfs_path *path,

				struct btrfs_ordered_extent *ordered_extent)

{

	struct btrfs_ordered_sum *sum;

	u64 bytenr;



	sum = list_entry(ordered_extent->list.next, struct btrfs_ordered_sum,

			 list);

	bytenr = sum->sums[0].bytenr;



	/*

	 * we don't care about the results, the point of this search is

	 * just to get the btree leaves into ram

	 */

	btrfs_lookup_csum(NULL, root->fs_info->csum_root, path, bytenr, 0);

}



/* as ordered data IO finishes, this gets called so we can finish

/* as ordered data IO finishes, this gets called so we can finish

 * an ordered extent if the range of bytes in the file it covers are

 * an ordered extent if the range of bytes in the file it covers are

 * fully written.

 * fully written.
@@ -1709,7 +1691,6 @@ static int btrfs_finish_ordered_io(struct inode *inode, u64 start, u64 end) 
	struct btrfs_trans_handle *trans;

	struct btrfs_trans_handle *trans;

	struct btrfs_ordered_extent *ordered_extent = NULL;

	struct btrfs_ordered_extent *ordered_extent = NULL;

	struct extent_io_tree *io_tree = &BTRFS_I(inode)->io_tree;

	struct extent_io_tree *io_tree = &BTRFS_I(inode)->io_tree;

	struct btrfs_path *path;

	int compressed = 0;

	int compressed = 0;

	int ret;

	int ret;
@@ -1717,32 +1698,9 @@ static int btrfs_finish_ordered_io(struct inode *inode, u64 start, u64 end) 
	if (!ret)

	if (!ret)

		return 0;

		return 0;





	/*

	 * before we join the transaction, try to do some of our IO.

	 * This will limit the amount of IO that we have to do with

	 * the transaction running.  We're unlikely to need to do any

	 * IO if the file extents are new, the disk_i_size checks

	 * covers the most common case.

	 */

	if (start < BTRFS_I(inode)->disk_i_size) {

		path = btrfs_alloc_path();

		if (path) {

			ret = btrfs_lookup_file_extent(NULL, root, path,

						       inode->i_ino,

						       start, 0);

			ordered_extent = btrfs_lookup_ordered_extent(inode,

								     start);

			if (!list_empty(&ordered_extent->list)) {

				btrfs_release_path(root, path);

				reada_csum(root, path, ordered_extent);

			}

			btrfs_free_path(path);

		}

	}



	if (!ordered_extent)

	ordered_extent = btrfs_lookup_ordered_extent(inode, start);

	ordered_extent = btrfs_lookup_ordered_extent(inode, start);

	BUG_ON(!ordered_extent);

	BUG_ON(!ordered_extent);



	if (test_bit(BTRFS_ORDERED_NOCOW, &ordered_extent->flags)) {

	if (test_bit(BTRFS_ORDERED_NOCOW, &ordered_extent->flags)) {

		BUG_ON(!list_empty(&ordered_extent->list));

		BUG_ON(!list_empty(&ordered_extent->list));

		ret = btrfs_ordered_update_i_size(inode, 0, ordered_extent);

		ret = btrfs_ordered_update_i_size(inode, 0, ordered_extent);

CRA Git | Maintained and supported by SUSTech CRA and CCSE