Commit efbe027e authored Dec 08, 2008 by Vaidyanathan Srinivasan Committed by Ingo Molnar Dec 08, 2008

sched: idle_balance() does not call load_balance_newidle()



Impact: fix SD_BALANCE_NEWIDLEand broaden its use

load_balance_newidle() does not get called if SD_BALANCE_NEWIDLE is
set at higher level domain (3-CPU) and not in low level domain (2-MC).

pulled_task is initialised to -1 and checked for non-zero which is
always true if the lowest level sched_domain does not have
SD_BALANCE_NEWIDLE flag set.

Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 5436499e

kernel/sched.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3685,7 +3685,7 @@ out_balanced:
		static void idle_balance(int this_cpu, struct rq *this_rq)
		{
		struct sched_domain *sd;
		int pulled_task = -1;
		int pulled_task = 0;
		unsigned long next_balance = jiffies + HZ;
		cpumask_t tmpmask;

Admin message