Commit efbdfdc2 authored by Andrew Lunn's avatar Andrew Lunn Committed by David S. Miller
Browse files

net: phy: Add support for asking the PHY its abilities 



Add support for runtime determination of what the PHY supports, by
adding a new function to the phy driver. The get_features call should
set the phydev->supported member with the features the PHY supports.
It is only called if phydrv->features is NULL.

This requires minor changes to pause. The PHY driver should not set
pause abilities, except for when it has odd cause capabilities, e.g.
pause cannot be disabled. With this change, phydev->supported already
contains the drivers abilities, including pause. So rather than
considering phydrv->features, look at the phydev->supported, and
enable pause if neither of the pause bits are already set.

Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
[hkallweit1@gmail.com: fixed small checkpatch complaint in one comment]
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 92ed2eb7

drivers/net/phy/phy_device.c

+15 −16
Original line number Diff line number Diff line
@@ -2236,7 +2236,14 @@ static int phy_probe(struct device *dev) 
	 * a controller will attach, and may modify one

	 * or both of these values

	 */

	if (phydrv->features) {

		linkmode_copy(phydev->supported, phydrv->features);

	} else {

		err = phydrv->get_features(phydev);

		if (err)

			goto out;

	}



	of_set_phy_supported(phydev);

	linkmode_copy(phydev->advertising, phydev->supported);
@@ -2256,20 +2263,8 @@ static int phy_probe(struct device *dev) 
	 * (e.g. hardware erratum) where the driver wants to set only one

	 * of these bits.

	 */

	if (test_bit(ETHTOOL_LINK_MODE_Pause_BIT, phydrv->features) ||

	    test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT, phydrv->features)) {

		linkmode_clear_bit(ETHTOOL_LINK_MODE_Pause_BIT,

				   phydev->supported);

		linkmode_clear_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,

				   phydev->supported);

		if (test_bit(ETHTOOL_LINK_MODE_Pause_BIT, phydrv->features))

			linkmode_set_bit(ETHTOOL_LINK_MODE_Pause_BIT,

					 phydev->supported);

		if (test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,

			     phydrv->features))

			linkmode_set_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,

					 phydev->supported);

	} else {

	if (!test_bit(ETHTOOL_LINK_MODE_Pause_BIT, phydev->supported) &&

	    !test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT, phydev->supported)) {

		linkmode_set_bit(ETHTOOL_LINK_MODE_Pause_BIT,

				 phydev->supported);

		linkmode_set_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
@@ -2315,7 +2310,11 @@ int phy_driver_register(struct phy_driver *new_driver, struct module *owner) 
{

	int retval;



	if (WARN_ON(!new_driver->features)) {

	/* Either the features are hard coded, or dynamically

	 * determine. It cannot be both or neither

	 */

	if (WARN_ON((!new_driver->features && !new_driver->get_features) ||

		    (new_driver->features && new_driver->get_features))) {

		pr_err("%s: Driver features are missing\n", new_driver->name);

		return -EINVAL;

	}

include/linux/phy.h

+6 −0
Original line number Diff line number Diff line
@@ -502,6 +502,12 @@ struct phy_driver { 
	 */

	int (*probe)(struct phy_device *phydev);



	/*

	 * Probe the hardware to determine what abilities it has.

	 * Should only set phydev->supported.

	 */

	int (*get_features)(struct phy_device *phydev);



	/* PHY Power Management */

	int (*suspend)(struct phy_device *phydev);

	int (*resume)(struct phy_device *phydev);

CRA Git | Maintained and supported by SUSTech CRA and CCSE