Commit efbb974d authored by Saeed Mahameed's avatar Saeed Mahameed
Browse files

net/mlx5e: vxlan: Return bool instead of opaque ptr in port_lookup() 



struct mlx5_vxlan_port is not exposed to the outside callers, it is
redundant to return a pointer to it from mlx5_vxlan_port_lookup(), to be
only used as a boolean, so just return a boolean.

Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 7a64ca86

drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c

+5 −4
Original line number Diff line number Diff line
@@ -77,9 +77,10 @@ static int mlx5_vxlan_core_del_port_cmd(struct mlx5_core_dev *mdev, u16 port) 
	return mlx5_cmd_exec_in(mdev, delete_vxlan_udp_dport, in);

}



struct mlx5_vxlan_port *mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port)

bool mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port)

{

	struct mlx5_vxlan_port *retptr = NULL, *vxlanp;

	struct mlx5_vxlan_port *vxlanp;

	bool found = false;



	if (!mlx5_vxlan_allowed(vxlan))

		return NULL;
@@ -87,12 +88,12 @@ struct mlx5_vxlan_port *mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 por 
	rcu_read_lock();

	hash_for_each_possible_rcu(vxlan->htable, vxlanp, hlist, port)

		if (vxlanp->udp_port == port) {

			retptr = vxlanp;

			found = true;

			break;

		}

	rcu_read_unlock();



	return retptr;

	return found;

}



static struct mlx5_vxlan_port *vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port)

drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.h

+2 −3
Original line number Diff line number Diff line
@@ -50,15 +50,14 @@ struct mlx5_vxlan *mlx5_vxlan_create(struct mlx5_core_dev *mdev); 
void mlx5_vxlan_destroy(struct mlx5_vxlan *vxlan);

int mlx5_vxlan_add_port(struct mlx5_vxlan *vxlan, u16 port);

int mlx5_vxlan_del_port(struct mlx5_vxlan *vxlan, u16 port);

struct mlx5_vxlan_port *mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port);

bool mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port);

#else

static inline struct mlx5_vxlan*

mlx5_vxlan_create(struct mlx5_core_dev *mdev) { return ERR_PTR(-EOPNOTSUPP); }

static inline void mlx5_vxlan_destroy(struct mlx5_vxlan *vxlan) { return; }

static inline int mlx5_vxlan_add_port(struct mlx5_vxlan *vxlan, u16 port) { return -EOPNOTSUPP; }

static inline int mlx5_vxlan_del_port(struct mlx5_vxlan *vxlan, u16 port) { return -EOPNOTSUPP; }

static inline struct mx5_vxlan_port*

mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port) { return NULL; }

static inline bool mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port) { return false; }

#endif



#endif /* __MLX5_VXLAN_H__ */

CRA Git | Maintained and supported by SUSTech CRA and CCSE